-
Notifications
You must be signed in to change notification settings - Fork 45
[Feature #21943] Add StringScanner#integer_at to extract capture group as Integer directly #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+181
−0
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dca7b9e
Add StringScanner#get_int to extract capture group as Integer directly
jinroq 4600b0a
Avoid C string allocation in StringScanner#get_int for small integers
jinroq 46a2e1d
Rename StringScanner#get_int to #integer_at
jinroq 82b93ad
Raise ArgumentError in StringScanner#integer_at for non-digit captures
jinroq b12e653
Use rb_int_parse_cstr in StringScanner#integer_at
jinroq 0948c72
Raise ArgumentError for empty capture in StringScanner#integer_at
jinroq 8726c03
Add edge case tests for StringScanner#integer_at
jinroq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this from between the
call-seqcomment andstrscan_integer_at()definition for RDoc?