Skip to content

nuttx: add SO_KEEPALIVE and TCP keepalive constants#5111

Merged
JohnTitor merged 1 commit into
rust-lang:mainfrom
no1wudi:main
May 26, 2026
Merged

nuttx: add SO_KEEPALIVE and TCP keepalive constants#5111
JohnTitor merged 1 commit into
rust-lang:mainfrom
no1wudi:main

Conversation

@no1wudi
Copy link
Copy Markdown
Contributor

@no1wudi no1wudi commented May 22, 2026

Description

rust-lang/rust#156790

Add SO_KEEPALIVE socket option and TCP_KEEPIDLE, TCP_KEEPINTVL, TCP_KEEPCNT
TCP-level keepalive constants for the NuttX target.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are included
  • Tested locally

@rustbot label +stable-nominated

@rustbot rustbot added S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels May 22, 2026
Copy link
Copy Markdown
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Removed "Fix" issue as you'd also need to update the libc version on r-l/r as well.
The CI failure should be unrelated but I don't have enough time to investigate today. If it continues I'll investigate it tomorrow or so.

View changes since this review

@JohnTitor
Copy link
Copy Markdown
Member

Now it has been fixed on the latest nightly, let's go ahead.

@JohnTitor JohnTitor added this pull request to the merge queue May 26, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 26, 2026
@JohnTitor JohnTitor added this pull request to the merge queue May 26, 2026
Merged via the queue into rust-lang:main with commit 4dc9caa May 26, 2026
99 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants