Try to recover from over-parsing in const item with missing semicolon #151247
+313
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
chenyukang
commented
Jan 17, 2026
chenyukang
force-pushed
the
yukang-fix-const-recover-151149
branch
from
0851ad6 to
b1dcdd1
Compare
estebank
reviewed
Jan 19, 2026
Comment on lines
26
to
32
| error[E0308]: mismatched types | ||
| --> $DIR/const-recover-semi-issue-151149.rs:15:19 | ||
| | | ||
| LL | const fn foo() -> &'static u8 { | ||
| | --- ^^^^^^^^^^^ expected `&u8`, found `()` | ||
| | | | ||
| | implicitly returns `()` as its body has no tail or `return` expression |
Contributor
There was a problem hiding this comment.
It'd be lovely if we could mark the function's tail expr as TyKind::Err so that we didn't emit a second error...
Member
Author
There was a problem hiding this comment.
is there any flag from parser we can set it directly?
Member
Author
There was a problem hiding this comment.
commit 471b929 will remove the later mismatched error, not sure there is any simpler solution, seems a little over engineering for a corner case.
chenyukang
force-pushed
the
yukang-fix-const-recover-151149
branch
from
ca9fa0b to
acb4b6a
Compare
chenyukang
force-pushed
the
yukang-fix-const-recover-151149
branch
from
acb4b6a to
68d28b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151149
r? @estebank