Disable default features from imageproc dependency#89
Open
JasperDeSutter wants to merge 2 commits into
Open
Conversation
Collaborator
|
How big a performance improvement is this in general terms? I have no objection to including it, there are probably a few places in the code where rayon might be useful as well. I'm going to have to evaluate though. |
Contributor
Author
|
I'm not sure it's worth it, I just noticed that turning off default features of imageproc also disabled rayon (it's on by default) so I didn't want to change that behavior in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...since it's pulling in all image formats (through
image/default), nullifying the image_formats feature.This makes rayon optional too, leaving more control to library users.