Skip to content

Draft: add SNAC flag to inet6 #4898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miawgogo wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −1
Open

Draft: add SNAC flag to inet6 #4898

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed1f67f
layers.inet6: add SNAC flag
miawgogo Jan 10, 2026
6177400
layers.inet6: document what IETF document the flag belongs to
miawgogo Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scapy/layers/inet6.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2208,7 +2208,8 @@ class ICMPv6ND_RA(_ICMPv6NDGuessPayload, _ICMPv6):
BitField("H", 0, 1),
BitEnumField("prf", 1, 2, icmp6ndraprefs), # RFC 4191
BitField("P", 0, 1),
Copy link

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The P flag on line 2210 also lacks an RFC comment reference. For consistency with the documentation standards used in this file (see line 2209 for example), consider adding the appropriate RFC reference for the P flag (NDP Proxy flag). This would make the codebase more maintainable and help developers understand the origin of each flag.

Suggested change
BitField("P", 0, 1),
BitField("P", 0, 1), # RFC 4389

Copilot uses AI. Check for mistakes.
BitField("res", 0, 2),
BitField("S", 0, 1), # draft-ietf-6man-snac-router-ra-flag-03
BitField("res", 0, 1),
ShortField("routerlifetime", 1800),
IntField("reachabletime", 0),
IntField("retranstimer", 0)]
Expand Down
Loading