Skip to content

SF-3806 Show all drafted books in formatting options book select#3902

Merged
RaymondLuong3 merged 1 commit into
masterfrom
feature/sf-3806-formatting-draft
May 28, 2026
Merged

SF-3806 Show all drafted books in formatting options book select#3902
RaymondLuong3 merged 1 commit into
masterfrom
feature/sf-3806-formatting-draft

Conversation

@RaymondLuong3
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 commented May 22, 2026

The formatting options page previously calculated books with completed drafts based on the books that exist in the current project. This is no longer the best option since books can be used for drafting that may not exist in the target project. This PR updates the behaviour to show any books that were drafted in the current draft build.


This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label May 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.90%. Comparing base (09d7200) to head (b54820e).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3902   +/-   ##
=======================================
  Coverage   80.90%   80.90%           
=======================================
  Files         631      631           
  Lines       40684    40681    -3     
  Branches     6600     6600           
=======================================
- Hits        32915    32913    -2     
- Misses       6729     6741   +12     
+ Partials     1040     1027   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman self-requested a review May 25, 2026 21:38
@pmachapman pmachapman self-assigned this May 25, 2026
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on RaymondLuong3).

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels May 25, 2026
@RaymondLuong3 RaymondLuong3 force-pushed the feature/sf-3806-formatting-draft branch from f93866e to b54820e Compare May 28, 2026 02:39
@RaymondLuong3 RaymondLuong3 added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels May 28, 2026
@RaymondLuong3 RaymondLuong3 merged commit 2c22164 into master May 28, 2026
33 checks passed
@RaymondLuong3 RaymondLuong3 deleted the feature/sf-3806-formatting-draft branch May 28, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants