SF-3691 Load base translation versification where specified#3904
SF-3691 Load base translation versification where specified#3904pmachapman wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3904 +/- ##
==========================================
+ Coverage 80.90% 80.93% +0.02%
==========================================
Files 630 630
Lines 40677 40724 +47
Branches 6602 6605 +3
==========================================
+ Hits 32909 32959 +50
+ Misses 6728 6726 -2
+ Partials 1040 1039 -1 ☔ View full report in Codecov by Sentry. |
RaymondLuong3
left a comment
There was a problem hiding this comment.
The code looks good. I am waiting for a draft to complete and then I can approve this.
@RaymondLuong3 reviewed 10 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
RaymondLuong3
left a comment
There was a problem hiding this comment.
I can see the draft after following the acceptance tests on the card. Nice!
@RaymondLuong3 made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).
src/SIL.XForge.Scripture/Services/LazyScrTextCollection.cs line 122 at r1 (raw file):
return null; string baseProjectPath = Path.Join(_settingsDirectory, projectId); if (!FileSystemService.DirectoryExists(baseProjectPath))
Wouldn't it make more sense to do:
string fullPath = Path.Join(baseProjectPath, "target");
if (!FileSystemService.DirectoryExists(fullPath)) return null;
return fullPath.
This PR updates Scripture Forge to load the versification from base projects, where present, and also to upload them to Serval if they are not in the drafting or training sources.
This change is