Skip to content

SF-3691 Load base translation versification where specified#3904

Open
pmachapman wants to merge 1 commit into
masterfrom
fix/SF-3691
Open

SF-3691 Load base translation versification where specified#3904
pmachapman wants to merge 1 commit into
masterfrom
fix/SF-3691

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented May 25, 2026

This PR updates Scripture Forge to load the versification from base projects, where present, and also to upload them to Serval if they are not in the drafting or training sources.


This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label May 25, 2026
@pmachapman pmachapman temporarily deployed to screenshot_diff May 25, 2026 01:03 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

❌ Patch coverage is 93.58974% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.93%. Comparing base (a9476dc) to head (1d02d2f).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...XForge.Scripture/Services/LazyScrTextCollection.cs 90.74% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3904      +/-   ##
==========================================
+ Coverage   80.90%   80.93%   +0.02%     
==========================================
  Files         630      630              
  Lines       40677    40724      +47     
  Branches     6602     6605       +3     
==========================================
+ Hits        32909    32959      +50     
+ Misses       6728     6726       -2     
+ Partials     1040     1039       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 self-assigned this May 25, 2026
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I am waiting for a draft to complete and then I can approve this.

@RaymondLuong3 reviewed 10 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the draft after following the acceptance tests on the card. Nice!

@RaymondLuong3 made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels May 26, 2026
Copy link
Copy Markdown
Collaborator

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nateowami made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).


src/SIL.XForge.Scripture/Services/LazyScrTextCollection.cs line 122 at r1 (raw file):

            return null;
        string baseProjectPath = Path.Join(_settingsDirectory, projectId);
        if (!FileSystemService.DirectoryExists(baseProjectPath))

Wouldn't it make more sense to do:

string fullPath = Path.Join(baseProjectPath, "target");
if (!FileSystemService.DirectoryExists(fullPath)) return null;

return fullPath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants