Skip to content

SF-3754 Fix draft history blank on generate draft page when online#3906

Merged
RaymondLuong3 merged 1 commit into
masterfrom
fix/SF-3754-draft-history
May 28, 2026
Merged

SF-3754 Fix draft history blank on generate draft page when online#3906
RaymondLuong3 merged 1 commit into
masterfrom
fix/SF-3754-draft-history

Conversation

@RaymondLuong3
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 commented May 25, 2026

The draft history list would not properly load if the user was initially offline when they navigated to the draft generation page. This change adds a subscriber to the online status service and triggers loading the history when a user returns online while on the draft generation page.


This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label May 25, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.90%. Comparing base (ec63e78) to head (48673ac).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3906   +/-   ##
=======================================
  Coverage   80.90%   80.90%           
=======================================
  Files         631      631           
  Lines       40681    40684    +3     
  Branches     6595     6600    +5     
=======================================
+ Hits        32912    32915    +3     
  Misses       6729     6729           
  Partials     1040     1040           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on RaymondLuong3).

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels May 25, 2026
@pmachapman pmachapman self-assigned this May 25, 2026
@RaymondLuong3 RaymondLuong3 force-pushed the fix/SF-3754-draft-history branch from 9f43dbb to 48673ac Compare May 28, 2026 02:28
@RaymondLuong3 RaymondLuong3 added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels May 28, 2026
@RaymondLuong3 RaymondLuong3 merged commit 09d7200 into master May 28, 2026
32 of 33 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/SF-3754-draft-history branch May 28, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants