Skip to content

fix(login): move password reset success message inside the form#3719

Merged
waleedlatif1 merged 1 commit intostagingfrom
fix/login-message
Mar 23, 2026
Merged

fix(login): move password reset success message inside the form#3719
waleedlatif1 merged 1 commit intostagingfrom
fix/login-message

Conversation

@waleedlatif1
Copy link
Collaborator

@waleedlatif1 waleedlatif1 commented Mar 23, 2026

Summary

The "Password reset successful" message was rendered above the form between the header and email field. Moved it inside the form, above the submit button alongside other form-level messages (captcha errors, etc).

Test plan

  • Reset password, verify success message appears above the Sign in button (not at the top of the page)

Was rendered above the form between the header and email field.
Now shows above the submit button alongside other form messages.
@vercel
Copy link

vercel bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Mar 23, 2026 6:39pm

Request Review

@cursor
Copy link

cursor bot commented Mar 23, 2026

PR Summary

Low Risk
Low risk UI-only change that repositions an existing success message; no auth flow, data handling, or API behavior is modified.

Overview
Moves the "password reset successful" banner (resetSuccessMessage) from above the login form to inside the form, placing it near other form-level messages (e.g., captcha/login errors) directly above the submit button.

Written by Cursor Bugbot for commit 81bf7f4. Configure here.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 23, 2026

Greptile Summary

This PR fixes a UI placement bug where the "Password reset successful" message appeared above the email/password form (between the header and the email field) instead of near the submit button where contextual form feedback belongs.

  • Removes the resetSuccessMessage block that was rendered outside the <form> element, above the email/password section.
  • Re-adds the same message block inside the <form>, just above the existing formError message and the submit button — consistent with how other form-level feedback (captcha errors, etc.) is displayed.
  • Minor class simplification: the outer div no longer carries mt-1 space-y-1, which were redundant for a single <p> child; space-y-8 on the form handles spacing naturally.
  • Edge case to be aware of: the success message is now gated behind the !isFalsy(getEnv('NEXT_PUBLIC_EMAIL_PASSWORD_SIGNUP_ENABLED')) check that wraps the entire <form>. If email/password auth is disabled, the message will never render. In practice this is not a real concern because password reset requires email auth to be enabled, but it is a behavioral change worth noting.

Confidence Score: 5/5

  • This PR is safe to merge — it is a focused, low-risk UI placement fix with no logic changes.
  • The change is minimal (12 lines removed, 6 lines added) and only affects where a success message is rendered. No logic, state, or API behavior is modified. The edge case where the message is now gated behind the email-auth feature flag is not a realistic concern because password reset inherently requires email auth to be enabled.
  • No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/(auth)/login/login-form.tsx Moves the password reset success message from outside the email/password form to inside it, just above the submit button and alongside other form-level messages. A minor class simplification (removal of space-y-1 and mt-1) is also included.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[LoginPage renders] --> B{resetSuccessMessage set?}
    B -- Yes (Old) --> C["Render success msg ABOVE form\n(between header and email field)"]
    B -- Yes (New) --> D{Email/password form enabled?}
    B -- No --> D
    D -- Yes --> E[Render email/password form]
    E --> F["Render success msg INSIDE form\n(above submit button)"]
    F --> G[Render Submit Button]
    D -- No --> H[Form hidden — success msg also hidden]
Loading

Reviews (1): Last reviewed commit: "fix(login): move password reset success ..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit daed8db into staging Mar 23, 2026
12 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/login-message branch March 23, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant