-
Notifications
You must be signed in to change notification settings - Fork 850
feat: support and flush chunks in the chat stream helper #1809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: zimeg-feat-ai-apps-chunks
Are you sure you want to change the base?
feat: support and flush chunks in the chat stream helper #1809
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## zimeg-feat-ai-apps-chunks #1809 +/- ##
=============================================================
+ Coverage 83.90% 83.93% +0.02%
=============================================================
Files 116 116
Lines 13168 13192 +24
=============================================================
+ Hits 11049 11073 +24
Misses 2119 2119 ☔ View full report in Codecov by Sentry. |
srtaalej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this ⭐ ⭐ ⭐ left some thoughts on the empty append - would love to hear your thoughts
| channel: str, | ||
| ts: str, | ||
| markdown_text: str, | ||
| markdown_text: Optional[str] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟 it is much easier to have both markdown and chunks optional!
| recipient_team_id="T0123456789", | ||
| recipient_user_id="U0123456789", | ||
| thread_ts="123.000", | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i tested this with an empty call to .append() and i think we should raise an error/ warning for when append is sent empty 🤔
Summary
This PR updates the
chat_streamhelper to support and flush "chunks".Testing
The following snippet might be useful in testing:
Category
/docs(Documents)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.