feat(experiment): inline sample descriptions in plain text#400
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
=======================================
Coverage ? 67.98%
=======================================
Files ? 218
Lines ? 18068
Branches ? 0
=======================================
Hits ? 12284
Misses ? 4631
Partials ? 1153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
There was a problem hiding this comment.
Notes and questions for the kind reader 🧠 💡
| Description: func(value string, index int) string { | ||
| return optionsForCategory[index].Description | ||
| }, |
There was a problem hiding this comment.
🔭 note: These descriptions aren't used for create selections so it's removed with these changes!
🪬 question: I notice samples does use descriptions and this causes outputs between "values" and "descriptions" different and am curious if we'd prefer to match that here?
slack-cli/cmd/project/create_template.go
Lines 34 to 99 in 2ad9485
| if desc := cfg.Description(opt, len(opts)); desc != "" { | ||
| key = opt + "\n " + desc | ||
| if desc := style.RemoveEmoji(cfg.Description(opt, len(opts))); desc != "" { | ||
| key = opt + " - " + desc |
There was a problem hiding this comment.
🐭 note: It'd be curious in a different separator but am unsure what reads best for most descriptions...
There was a problem hiding this comment.
selection and code looks a lot cleaner 🙌 thanks for making these updates ❤️
i will say though the inline description with "-" feels a bit dense visually — especially when scanning a longer list.
i think itd be worth it to explore (in a followup pr) a subtler separator or dimming the description text to create more visual hierarchy between the option name and its description 🤔
mwbrooks
left a comment
There was a problem hiding this comment.
Nice improvement
suggestion: The survey prompts use a nice style where the description is grey. Visually, it's easy to separate the Option ("Starter App") from Description ("Some description about the app"). This update loses the grey text, which makes it a lot harder to distinguish what the option is.

Changelog
Summary
This PR inlines sample descriptions in plain text for the
samplescommand and moves docs reference to help text and also removes emojis from descriptions to avoid output issues.Preview
Before
After
Requirements