Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage 67.90% 67.90%
=======================================
Files 218 218
Lines 18050 18050
=======================================
+ Hits 12256 12257 +1
+ Misses 4640 4638 -2
- Partials 1154 1155 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| # VHS demo recordings | ||
| demos/ |
There was a problem hiding this comment.
question(non-blocking): Curious if you considered having our VHS demos checked into version control? Just curious if we'd ever want to re-generate older recordings to show an updated UI.
There was a problem hiding this comment.
📸 Such an interesting idea! Without knowing good practices to this I left it for later thinking to be honest-
I'd be so curious to versioning .tape files with the docs 📚
Our hidden docgen command might be extended to require vhs to regenerate all recordings with the latest release perhaps? Would love to learn recommendations to this and thoughts from @lukegalbraithrussell!
Changelog
Summary
This PR adds a
claudeskill to record demos for PR previews using thevhspackage.Preview
📸 Example of generated "tape" and GIF - the app existed ahead of time which might be useful for intricate setups:
Requirements