[Chore] Sui gRPC client migration by faisal-chainlink · Pull Request #1028 · smartcontractkit/chainlink-deployments-framework

faisal-chainlink · 2026-06-04T17:47:27Z

This PR includes the following changes:

Updates the Sui SDK references to correspond to the gRPC migration changes in chainlink-sui. This primarily includes dropping the ISuiAPI reference (old version of the Sui SDK) in favor of using a client interface exported by chainlink-sui/relayer/client.
Update the mocked interface for Sui in this repo.
General lint and deps version bumps (e.g., MCMS dep).

changeset-bot · 2026-06-04T17:47:36Z

⚠️ No Changeset found

Latest commit: 0865474

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

FelixFan1992 · 2026-06-09T13:33:53Z

can you fix the tests? and we will need a changeset for a new version.

faisal-chainlink · 2026-06-09T16:28:43Z

can you fix the tests? and we will need a changeset for a new version.

Rebasing from main resolved the test issues; there was an unrelated blocker.

Copilot

Pull request overview

This PR migrates the Sui integration from the block-vision HTTP RPC client interface to the chainlink-sui gRPC-backed PTB client, updating providers, adapters, and tests to use the new client and generating new mocks for the updated interfaces.

Changes:

Switch Sui Chain.Client and providers to use chainlink-sui/relayer/client (SuiPTBClient) and add a helper to derive a gRPC target from an HTTP RPC URL.
Update MCMS chain-access adapter and Sui tests to work with the new client interfaces.
Regenerate Sui mocks via mockery and update Go module dependencies accordingly.

Reviewed changes

Copilot reviewed 10 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
go.mod	Adds `go-cache`, bumps/adjusts deps for the new Sui client + related modules.
go.sum	Updates checksums for dependency changes.
datastore/catalog/remote/main_test.go	Adjusts catalog testcontainer setup/cleanup usage.
chain/sui/sui_chain.go	Changes Sui chain client type to the new PTB client.
chain/sui/sui_chain_test.go	Updates balance read test to use the new PTB client API/return types.
chain/sui/provider/rpc_provider.go	Creates the PTB client (gRPC) instead of the old HTTP RPC client.
chain/sui/provider/ctf_provider.go	Creates the PTB client for CTF-based Sui nodes.
chain/sui/client.go	Adds `NewPTBClientFromNodeURL` + URL→gRPC-target conversion helper.
chain/mcms/adapters/chain_access.go	Updates `SuiClient` return type to `BindingsClient`.
chain/mcms/adapters/chain_access_test.go	Updates tests to use the new Sui mocks (and removes one assertion).
chain/sui/mocks/sui_signer.go	New generated mock for Sui signer.
chain/sui/mocks/sui_ptb_client.go	New generated mock for the PTB client (adds `go-cache` dep).
chain/sui/mocks/bindings_client.go	New generated mock for bindings client interface.
.mockery.yml	Updates mockery targets from block-vision interfaces to `chainlink-sui` interfaces.

Files not reviewed (3)

chain/sui/mocks/bindings_client.go: Language not supported
chain/sui/mocks/sui_ptb_client.go: Language not supported
chain/sui/mocks/sui_signer.go: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 16 changed files in this pull request and generated 3 comments.

Files not reviewed (3)

chain/sui/mocks/bindings_client.go: Language not supported
chain/sui/mocks/sui_ptb_client.go: Language not supported
chain/sui/mocks/sui_signer.go: Language not supported

FelixFan1992 · 2026-06-11T19:36:28Z

@@ -223,7 +224,11 @@ func (p *CTFChainProvider) startContainer(
 	url = result.url
 	fauceturl = fmt.Sprintf("http://%s:%s", "127.0.0.1", result.faucetPort)


will this kind of faucet URL still work after RPC shuts down?

the faucet runs as a separate service which isn't the same as the RPC node, they don't mention it in their migration guide: https://sdk.mystenlabs.com/sui/migrations/sui-2.0

Copilot

Pull request overview

Copilot reviewed 11 out of 16 changed files in this pull request and generated 1 comment.

Files not reviewed (3)

chain/sui/mocks/bindings_client.go: Generated file
chain/sui/mocks/sui_ptb_client.go: Generated file
chain/sui/mocks/sui_signer.go: Generated file

 	suiClient, ok := a.SuiClient(999)
 	require.False(t, ok)
 	require.Nil(t, suiClient)


cl-sonarqube-production · 2026-06-12T14:03:25Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

faisal-chainlink added 2 commits June 4, 2026 21:39

initial draft

f20f69e

initial draft

e26b8cd

faisal-chainlink added 6 commits June 5, 2026 20:22

Merge branch 'main' into chore/sui-grpc-client-migration

5a75e9a

Merge branch 'main' into chore/sui-grpc-client-migration

3fd4b96

update deps

1a74ee3

update Sui mocks and deps

f2a4d03

update deps in /deployment

e08b190

update Sui balance check test

0f4bdb0

faisal-chainlink mentioned this pull request Jun 8, 2026

[Chore] Re-enable E2E tests smartcontractkit/chainlink-sui#401

Merged

faisal-chainlink added 3 commits June 9, 2026 19:58

merge main

d550dc8

update chainlink-sui dep ref

7431cbe

update mcms dep ref

e3d6291

faisal-chainlink added 5 commits June 11, 2026 18:30

update mcms and chainlink-sui deps

cd72a9e

Merge branch 'main' into chore/sui-grpc-client-migration

944da42

tidy

a392659

update MCMS ref

3f627a3

lint fixes

d2a5c25

faisal-chainlink force-pushed the chore/sui-grpc-client-migration branch from adc8557 to d2a5c25 Compare June 11, 2026 16:15

faisal-chainlink marked this pull request as ready for review June 11, 2026 16:20

faisal-chainlink requested a review from a team as a code owner June 11, 2026 16:20

Copilot AI review requested due to automatic review settings June 11, 2026 16:20

Copilot started reviewing on behalf of faisal-chainlink June 11, 2026 16:20 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread datastore/catalog/remote/main_test.go Outdated

Comment thread chain/mcms/adapters/chain_access_test.go

Comment thread chain/sui/client.go

Comment thread chain/sui/client.go

faisal-chainlink and others added 2 commits June 11, 2026 20:34

add sui client test to address code cov

b143dda

Potential fix for pull request finding

3ad0d1b

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 11, 2026 16:35

Copilot started reviewing on behalf of faisal-chainlink June 11, 2026 16:35 View session

lint fixes

ef0b7f8

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread chain/sui/client.go

Comment thread chain/sui/provider/rpc_provider.go

Comment thread chain/mcms/adapters/chain_access_test.go

faisal-chainlink requested review from ChrisAmora, FelixFan1992 and stackman27 June 11, 2026 19:33

FelixFan1992 reviewed Jun 11, 2026

View reviewed changes

faisal-chainlink mentioned this pull request Jun 11, 2026

[NONEVM-5227] Chore: SUI gRPC client migration smartcontractkit/chainlink#22823

Draft

FelixFan1992 approved these changes Jun 11, 2026

View reviewed changes

Merge branch 'main' into chore/sui-grpc-client-migration

0865474

Copilot AI review requested due to automatic review settings June 12, 2026 13:55

Copilot started reviewing on behalf of faisal-chainlink June 12, 2026 13:56 View session

Copilot AI reviewed Jun 12, 2026

View reviewed changes

Comment thread chain/mcms/adapters/chain_access_test.go

Comment on lines 57 to 59

suiClient, ok := a.SuiClient(999)

require.False(t, ok)

require.Nil(t, suiClient)

ecPablo approved these changes Jun 12, 2026

View reviewed changes

faisal-chainlink added this pull request to the merge queue Jun 12, 2026

Merged via the queue into main with commit e31c0ae Jun 12, 2026
30 checks passed

faisal-chainlink deleted the chore/sui-grpc-client-migration branch June 12, 2026 19:20

		@@ -223,7 +224,11 @@ func (p *CTFChainProvider) startContainer(
		url = result.url
		fauceturl = fmt.Sprintf("http://%s:%s", "127.0.0.1", result.faucetPort)

Conversation

faisal-chainlink commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

FelixFan1992 commented Jun 9, 2026

Uh oh!

faisal-chainlink commented Jun 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FelixFan1992 Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

faisal-chainlink Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

cl-sonarqube-production Bot commented Jun 12, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

faisal-chainlink commented Jun 4, 2026 •

edited

Loading

changeset-bot Bot commented Jun 4, 2026 •

edited

Loading