OPDATA-6934 add delta and snapshot modes + related linter refactoring…#806
Open
mmcallister-cll wants to merge 2 commits into
Open
OPDATA-6934 add delta and snapshot modes + related linter refactoring…#806mmcallister-cll wants to merge 2 commits into
mmcallister-cll wants to merge 2 commits into
Conversation
…. Also allow numbers in endpoint names
Contributor
|
👋 mmcallister-cll, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
NPM Publishing labels 🏷️🟢 This PR has valid version labels and will cause a |
Contributor
|
Can you provide more context in the PR description? From the title and description it sounds like this PR does 4 different things. Is that necessary? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…. Also allow numbers in endpoint names
Adds optional options.batchSubscribeMode to the WebSocketBatchBuilders to configure whether to send subscriptions.desired (full snapshot) or subscriptions.new (delta) upon a new subscription being present.
https://smartcontract-it.atlassian.net/browse/OPDATA-6934
To be used in Nobi EA.