fix: cleanup pending acks on timeout to prevent memory leak #5442
+102
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `emitWithAck` with a timeout, if clients don't respond and the timeout triggers, the ack callbacks remain in `socket.acks` Map indefinitely, causing a memory leak. This fix: - Returns a cleanup function from `broadcastWithAck` that removes pending acks from all sockets that received the packet - Calls the cleanup function when timeout occurs in broadcast-operator - Adds test cases to verify acks are cleaned up after timeout Fixes socketio#4984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
When using
emitWithAckwith a timeout, if clients don't respond and the timeout triggers, the ack callbacks remain insocket.acksMap indefinitely, causing a memory leak.New behavior
The ack callbacks are cleaned up from
socket.acksMap when the timeout occurs, preventing memory leak.Other information (e.g. related issues)
Fixes #4984