Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
| useAssets_(() => renderAsset(asset, nonce)); | ||
| entity.ssrIdx = ssrRequestAssets.length - 1; | ||
| useAssets_(() => renderAsset(asset, nonce) as any); | ||
| if (ssrRequestAssets) { |
There was a problem hiding this comment.
im not sure if these changes are correct or needed
| // used on native HTML elements during SSR transformation. The previous | ||
| // implementation used JSX (<style {...props.attrs}> etc.) which triggered the | ||
| // bug. Instead we build the HTML strings directly — these assets are only | ||
| // ever rendered during SSR so reactive JSX is unnecessary. |
There was a problem hiding this comment.
these changes are probably unneeded
There was a problem hiding this comment.
seems that they are needed in some capacity
| "solid-js": "2.0.0-beta.0", | ||
| "source-map-js": "^1.2.1", | ||
| "srvx": "^0.9.1", | ||
| "terracotta": "^1.0.6", |
There was a problem hiding this comment.
removed this dep for now as it doesn't support 2.0 yet
| const args = url.searchParams.get("args"); | ||
| if (args) { | ||
| const result = (await deserializeFromJSONString(args)) as any[]; | ||
| // args may be in seroval chunk format (from createServerReference) |
| import { Dialog, DialogOverlay, DialogPanel, Select, SelectOption } from "terracotta"; | ||
| import { Errored, For, Show, Loading, createMemo, createSignal } from "solid-js"; | ||
| import { Portal } from "@solidjs/web"; | ||
| // @ts-ignore - terracotta removed during Solid 2.0 migration; stubbed below |
There was a problem hiding this comment.
removed terracotta temporily
|
We can probably use |
2 participants
PR Checklist
Seeing what It take to update SolidStart to use Solid 2.0 beta. The bare example works with no router.
These are the following outstanding issues