Fix isCommitted() check in response header filters#4115
Open
chenws1012 wants to merge 1 commit into
Open
Conversation
Add isCommitted() check to prevent UnsupportedOperationException when modifying response headers after request is rejected by filters like RequestRateLimiter. Affected filters: - SetResponseHeaderGatewayFilterFactory - DedupeResponseHeaderGatewayFilterFactory - SecureHeadersGatewayFilterFactory - RewriteResponseHeaderGatewayFilterFactory - RewriteLocationResponseHeaderGatewayFilterFactory Fixes spring-cloudgh-3718 Signed-off-by: chenwenshun <chenwenshun@gmail.com>
chenws1012
force-pushed
the
fix/response-header-iscommitted-check
branch
2 times, most recently
from
f0e9f45 to
41a238a
Compare
|
I am encountering the same problem in NettyRoutingFilter: It would be great if this could also be included in the fix. |
ryanjbaxter
requested changes
May 27, 2026
Contributor
ryanjbaxter
left a comment
ryanjbaxter
left a comment
There was a problem hiding this comment.
Can you submit this against the 4.3.x branch?
| .then(Mono.fromRunnable(() -> dedupe(exchange.getResponse().getHeaders(), config))); | ||
| return chain.filter(exchange).then(Mono.fromRunnable(() -> { | ||
| if (!exchange.getResponse().isCommitted()) { | ||
| dedupe(exchange.getResponse().getHeaders(), config); |
Contributor
There was a problem hiding this comment.
Similar to what AddResponseHeaderGatewayFilterFactory does it would be good to add the check to dedupe. Similar comment applies to the other filters
| * fix for issue #3718 where filters like RequestRateLimiter commit the response, but | ||
| * post-processing response header filters still try to modify headers. | ||
| * | ||
| * @author issue #3718 |
Contributor
There was a problem hiding this comment.
Please fix the author tag
| * A filter that commits the response without calling chain.filter(), simulating | ||
| * behavior of filters like RequestRateLimiter when denying a request. | ||
| */ | ||
| static class CommitResponseFilter implements GatewayFilter { |
Contributor
There was a problem hiding this comment.
This should probably implement Ordered to make runs before the other filters.
spencergibb
reviewed
May 27, 2026
Member
spencergibb
left a comment
spencergibb
left a comment
There was a problem hiding this comment.
Without having investigated much, this looks like a bandaid to a bigger problem. I'd rather fix the root problem than cover it up. This looks to just do nothing, which seems worse to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
isCommitted()check to response header filters to preventUnsupportedOperationExceptionwhen response is already committedby filters like
RequestRateLimiter.Fix versions affected
What is the issue related to this PR?
Fixes #3718
How was this patch tested?
Existing tests pass. The issue occurs when:
With this fix, filters check
isCommitted()before modification.Checklist
./mvnw test)