GH-3797 change: make QdrantVectorStore contentFieldName configurable #5262
+41
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| metadata.put(DocumentMetadata.DISTANCE.value(), 1 - point.getScore()); | ||
|
|
||
| var content = (String) metadata.remove(CONTENT_FIELD_NAME); | ||
| var content = (String) metadata.remove(DEFAULT_CONTENT_FIELD_NAME); |
Member
There was a problem hiding this comment.
Now that the content field name is configurable, we should be using the content field name instead of the default one.
Author
There was a problem hiding this comment.
Thank you for the feedback. The intention was to handle null safety when contentFieldName was not configured, but it was wrong. It will be corrected
Member
There was a problem hiding this comment.
@destiny3912 Are you planning to update the PR to fix this? or, do you want me to handle when merging? Thank you
Author
There was a problem hiding this comment.
@ilayaperumalg I fix it now, please check it, Thank you
Signed-off-by: jiho lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request changes the content field name of the Qdrant Vector Store to enable setting via auto configuration in hard-coded "doc_contents"
fix #3797
Changes
Usage
Add property spring.ai.vectorstore.qdrant.content-field-name to application.yml