refactor(boil)!: Refactor internal code structure#1451
Open
refactor(boil)!: Refactor internal code structure#1451
Conversation
This also restructures the CLI interface slightly: - `boil show images` is now `boil image list` - `boil images` is an alias for `boil image list` This is done in preparation for an upcoming `boil image check` command.
|
|
||
| #[derive(Clone, Debug)] | ||
| pub struct Image { | ||
| pub struct ImageSelector { |
Member
There was a problem hiding this comment.
Could do with a brief doc-comment, but that's unrelated to this change
NickLarsenNZ
approved these changes
Apr 14, 2026
| (ANNOTATION_CREATED.to_owned(), date_time.clone()), | ||
| (ANNOTATION_REVISION.to_owned(), revision), | ||
| (LABEL_BUILD_DATE.to_owned(), date_time), | ||
| (DOCKER_LABEL_BUILD_DATE.to_owned(), date_time), |
Member
There was a problem hiding this comment.
Is it a docker thing, or general container thing?
Member
Author
There was a problem hiding this comment.
Yeah, labels are a Docker thing. OCI calls them annotations. Also, the annotation containing the "build date" is called org.opencontainers.image.created.
| } | ||
| // TODO (@Techassi): These tests are currently commented out because rstest | ||
| // contains a bug related to the Rust's core library and the local core | ||
| // module. It is fixed upstream, but not released yet. |
Member
There was a problem hiding this comment.
We should maybe add a link to the issue/PR so anyone can see when it's done, but I assume you will take care of it, so not a big deal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also restructures the CLI interface slightly:
boil show imagesis nowboil image listboil imagesis an alias forboil image listThis is done in preparation for an upcoming
boil image checkcommand. These changes require changes instackabletech/actionswhen a new version of boil is released.