chore: Describe RBAC rules, remove unnecessary rules#717
Merged
NickLarsenNZ merged 13 commits intomainfrom Apr 9, 2026
Merged
Conversation
17 tasks
NickLarsenNZ
commented
Apr 2, 2026
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
…clusterrole Not needed for crd maintenance
Not needed for clusterDomain detection
… product clusterrole All secrets/configmaps are mounted, not accessed via the superset app
The operator manages events
…close to each other
…tor.yaml and clusterrole-product.yaml
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#798
Note
This was initially generated by a coding assistant to see how well it can inspect code and review the RBAC rules. the changes will be properly checked before reviews are requested.
Operator ClusterRole rule removals
podsrule (all verbs) - operator never manages pods directly; StatefulSets create themsecretsrule (all verbs) - operator only references secret names in Pod specs; never reads or manages themendpointsrule (all verbs) - auto-created by Kubernetes when a Service is created; never managed directlysecretsentry - was listed twice in the same ruleupdateverb on all resources - never used; all writes use Server-Side Apply (create + patch)watchverb onserviceaccounts- not watched by the controllerwatchverb onrolebindings- not watched by the controllerwatchverb onpoddisruptionbudgets- not watched by the controllerwatchverb onlisteners- not watched by the controllerdeleteverb onjobs- jobs are not tracked for orphan cleanuppatchverb onsupersetclusters- operator only patches the /status subresource, not the main resourcepatchverb ondruidconnections- operator only patches the /status subresource, not the main resourceget,list,watchverbs ondruidconnections/status- was bundled withdruidconnections; status subresource only needspatchgetverb oncustomresourcedefinitions- not needed outside of CRD maintenance; list and watch (now unconditional) cover read accessnodeslist/watch rule - not needed; only nodes/proxy get is required for cluster domain detectionProduct ClusterRole rule removals
configmaps,secrets,serviceaccountsget rule - Superset pods don't need to read these Kubernetes resourcesevents.k8s.ioevents create/patch rule - Superset pods don't emit Kubernetes events