Skip to content

build: remove need for custom eslint-plugin-stdlib bundle#10948

Draft
Planeshifter wants to merge 1 commit intodevelopfrom
philipp/gh62-avoid-eslint-bundle
Draft

build: remove need for custom eslint-plugin-stdlib bundle#10948
Planeshifter wants to merge 1 commit intodevelopfrom
philipp/gh62-avoid-eslint-bundle

Conversation

@Planeshifter
Copy link
Member

Resolves stdlib-js/metr-issue-tracker#67.

Description

What is the purpose of this pull request?

This pull request:

  • Replaces the Browserify bundling step for eslint-plugin-stdlib with a thin proxy at etc/eslint/plugin/ installed via a file: devDependency in package.json.
  • Removes tools/make/lib/init/eslint.mk and the associated init-eslint-plugins / clean-eslint-plugins Make targets, since npm install now handles plugin setup automatically.
  • Node.js module resolution naturally resolves all @stdlib/... requires from within the lib/node_modules/ tree, making the 4.2MB Browserify bundle unnecessary.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code.


@stdlib-js/reviewers

Replace the Browserify bundling step with a thin proxy at
`etc/eslint/plugin/` installed via a `file:` devDependency.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter changed the title build: use file: dependency for eslint-plugin-stdlib build: remove need for custom eslint-plugin-stdlib bundle Mar 15, 2026
"eslint-plugin-expect-type": "^0.2.3",
"eslint-plugin-import": "^2.29.0",
"eslint-plugin-jsdoc": "^46.8.2",
"eslint-plugin-stdlib": "file:./etc/eslint/plugin",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the ESLint v9 migration, this will become unnecessary and we won't need a plugin at all anymore.

@socket-security

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Avoid custom ESLint plugin bundling

1 participant