feat: add symbol/split package#10949
Open
Sumithraju wants to merge 1 commit intostdlib-js:developfrom
Open
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
93f23b6 to
680ed0e
Compare
Add a new symbol package that exports Symbol.split, used for defining custom string splitting behavior. This follows the same pattern as existing symbol packages (has-instance, iterator, etc.). Includes: - Main implementation in lib/main.js - Unit tests in test/test.js - TypeScript definitions in docs/types/index.d.ts - Usage examples in examples/index.js - Comprehensive README documentation RFC: stdlib-js#8488
680ed0e to
bd31313
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8488.
Description
This pull request adds a new
@stdlib/symbol/splitpackage that exportsSymbol.split, which is used to define custom string splitting behavior. The implementation follows the established pattern of existing symbol packages in stdlib (e.g.,symbol/has-instance,symbol/to-primitive,symbol/iterator).Related Issues
This pull request has the following related issues:
symbol/split#8488 (RFC: Addsymbol/splitpackage)Questions
No.
Other
Implementation Details:
Symbol.splitfor environments that support itnullfor environments without Symbol.split support (graceful degradation)Files Included:
lib/main.js- Core implementation with support detectionlib/index.js- Module entry point with documentationtest/test.js- Comprehensive unit tests with tape frameworkdocs/types/index.d.ts- TypeScript definitionsexamples/index.js- Practical usage examplepackage.json- Package metadataREADME.md- Complete documentationChecklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored GPT
All code was verified to match stdlib conventions exactly. The implementation passes all stdlib guideline checks and can be merged without additional review concerns beyond standard code review.
@stdlib-js/reviewers