Skip to content

fix: store AgentCore browser client for proper session cleanup #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omerio wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: store AgentCore browser client for proper session cleanup #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/strands_tools/browser/agent_core_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ async def create_browser_session(self) -> PlaywrightBrowser:

logger.info(f"started Bedrock AgentCore browser session: {session_id}")

# Store the client so close_platform() can properly terminate the session
self._client_dict[session_id] = session_client

# Get CDP connection details
cdp_url, cdp_headers = session_client.generate_ws_headers()

Expand Down
Loading