fix: add consent gate and newline sanitization to cron tool#468
Merged
pgrayy merged 2 commits intoMay 15, 2026
Merged
Conversation
The cron tool wrote LLM-supplied schedule, command, and raw entry strings directly into the user's crontab with no confirmation prompt and no newline sanitization (except on the description field). This adds: - A consent gate via BYPASS_TOOL_CONSENT (matching shell, editor, file_write, and other tools) through a shared _write_crontab function that all mutating paths must use. - Newline sanitization on composed cron lines via _sanitize_cron_line, preventing injection of hidden extra crontab entries.
zastrowm
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The cron tool writes LLM-supplied schedule, command, and raw entry strings directly into the user's crontab with no confirmation prompt and incomplete newline sanitization (only the description field is sanitized). This makes it possible for an agent to silently install persistent cron jobs, and for newline injection to smuggle hidden entries past any future consent prompt.
This PR adds:
BYPASS_TOOL_CONSENT(matching shell, editor, file_write, and other tools) through a shared_write_crontabfunction that all mutating paths must use._sanitize_cron_line, preventing injection of hidden extra crontab entries through any input field.Type of Change
Bug fix
Testing
hatch test tests/test_cron.py)save/test_cron_security.py) runs 8 tests against the real crontab, all passChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.