When splitting lines for the cross-PR checkout also split on \r\n#249
Open
ahoppen wants to merge 1 commit intoswiftlang:mainfrom
Open
When splitting lines for the cross-PR checkout also split on \r\n#249ahoppen wants to merge 1 commit intoswiftlang:mainfrom
ahoppen wants to merge 1 commit intoswiftlang:mainfrom
Conversation
It seems like GitHub sometime in the last year started representing newlines in the PR description using \r\n instead of \n. Respect those as well to split the description into lines and find the linked PR indicator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like GitHub sometime in the last year started representing newlines in the PR description using \r\n instead of \n. Respect those as well to split the description into lines and find the linked PR indicator.
For now, a workaround is to put Linked PR: in the first line of the PR description.