Conversation
… speed -> settings default (if custom) -> slow fee rate -> 1
Member
Author
|
Testing ... |
Member
Author
Fixed 7a6c9ce
Fixed af32125
Fixed 39cd7a6
zero-amount.webmfixed-amount.webm |
pwltr
previously approved these changes
Apr 2, 2026
This comment has been minimized.
This comment has been minimized.
ovitrif
reviewed
Apr 2, 2026
Collaborator
ovitrif
left a comment
There was a problem hiding this comment.
Added some nits, going to test more
…t.kt Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
ovitrif
approved these changes
Apr 2, 2026
Collaborator
ovitrif
left a comment
There was a problem hiding this comment.
tAck
Review Pass 2 - Tests
- test if swipe gets stuck - was encountered once yesterday - all ok now
- send unified
- no amount
- amount + quickpay
- set fee to fast → should switch to BTC → change back to INSTANT → should switch to LN
- try with amount below dust limit → should not allow switch to BTC
- send LN
- no amount
- amount + quickpay
- pin4pay ON + quickpay
- send BTC
- no amount
- amount
- pin4pay + bio ON
Contributor
|
test comment |
This comment was marked as low quality.
This comment was marked as low quality.
Member
Author
|
@piotr-iohk probably the debounce again |
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements v60 design for the send flow, matching iOS PR #488.
FIGMA
Description
This PR:
SendSectionViewcomponentSwipeToConfirmfor driving animationsPreview
In QA notes
QA Notes
1. Show/Hide Details Toggle
On-chain payment:
Screen_recording_20260330_084538.webm
Lightning payment:
empty-notes.webm
with-note.webm
Tags
2. Send From / Payment Method Switch
Unified invoice (BIP21) - Confirm screen:
Screen_recording_20260330_094741.webm
Unified invoice - Button disabled when conditions not met:
above-savings.webm
dust-and-above-spending.webm
Non-unified invoice - Confirm screen:
Amount screen switching:
3. Fee Rate Screen - Instant Option
Unified payment:
Non-unified payment:
4. Custom Fee Defaults
Screen_recording_20260330_103530.webm
5. Relative Invoice Expiry
6. Layout & Spacing
7. Regression
transfer-and-boost.webm