feat: update external success screen text and image#883
Open
feat: update external success screen text and image#883
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
auto-merge was automatically disabled
April 6, 2026 11:20
Pull request was converted to draft
Member
Author
|
Still fixing my setup to record lnurl channel test |
# Conflicts: # app/src/main/java/to/bitkit/ui/screens/wallets/SpendingWalletScreen.kt
Collaborator
|
Used cherry-pick to port the fix described here, because the original PR where I fixed it wasn't targeting |
…into feat/external-success-new-text # Conflicts: # CHANGELOG.md
ovitrif
approved these changes
Apr 6, 2026
Collaborator
There was a problem hiding this comment.
tAck
Updates I did:
- Ported the fix for the secondary button size so the fix lands into
masterearlier, previous fix I did was on PR #882 which is stacked on a draft PR. (merging should not be such a big pain as I simply cherry-picked the commits 🤞🏻 ) - updated the changelog entry to be more "public-facing" friendly
For testing, I compared vs. Figma:
PRO tip: You can open a channel manually to the LSP node, making it the easiest flow to test these design updates.
Flow steps:
- Drawer > App Status > LN Node > Scroll & tap trusted peer card to copy > back
- Lightning Connections > Add > Advanced > Manual Setup > Paste Node URI
Warning: note that you won't be able to send LN from another mobile device to this channel, so better close it right after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIGMA
This PR:
Description
Updates the external node connection success screen to match the new Figma design. The title now reads "Channel Opening" (with "Opening" accented in purple), the illustration is a lightning bolt, and the nav bar shows "Spending Balance" instead of the shared "Lightning Connection" title.
Preview
QA Notes
Flow 1: Manual External Node Setup
manual.webm
Flow 2: LNURL Channel (QR Scan)