Conversation
|
I tried using Haze library for the SecondaryButton but didn't get a good result |
This comment has been minimized.
This comment has been minimized.
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
tAck
LGTM but there is no glass blur to be seen:

According to Claude, we are not doing background blur. This is a common issue that I know in Android Compose for like 3-5 years: the blur that it has is content blur (aka layer blur in Figma), so it will only blur other elements you render inside. It will not blur elements behind (aka. background blur in Figma).
| frameworkPaint.maskFilter = android.graphics.BlurMaskFilter( | ||
| blurRadiusPx, | ||
| android.graphics.BlurMaskFilter.Blur.NORMAL, |
There was a problem hiding this comment.
android.graphics.BlurMaskFilter is referenced by its fully-qualified name instead of being imported, violating CLAUDE.md: ALWAYS add imports instead of inline fully-qualified names.
Add import android.graphics.BlurMaskFilter at the top of the file and replace both inline usages:
frameworkPaint.maskFilter = BlurMaskFilter(
blurRadiusPx,
BlurMaskFilter.Blur.NORMAL,
)| .clickableAlpha( | ||
| enabled = enabled && !isLoading, | ||
| onClick = onClick, | ||
| ), |
There was a problem hiding this comment.
Trailing comma on modifier = ... at a call site violates CLAUDE.md: NEVER add a trailing comma to modifier = ... at call sites.
| ), | |
| ) |
Description
This PR polishes the Primary, Secondary, and Tertiary buttons to match the Figma design specs:
glassBlurmodifierGradientCircularProgressIndicatorfor loading statesPreview
Screen_recording_20260403_132257.webm
QA Notes
Primary Button
Secondary Button
Tertiary Button
Loading states — all three buttons show gradient progress indicator when loading
Disabled states — verify icons dim to White32, borders become transparent