Optimise locking when storing types per key#913
Open
systemed wants to merge 1 commit into
Open
Conversation
This was referenced Jun 4, 2026
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #877 @pa5cal identified a slowdown caused by locking when we write to
attributeMapfor a given layer, which we use to record the types for each attribute in the vector tile (eventually written into thevector_layersJSON).We had some discussion of fixes in the thread, and then in true "you wait three months for a bus" fashion, we also have #912 which also provides a fix. This PR takes from those to provide the simplest possible solution:
unordered_set, which means we can usecountto avoid thefind/endthreading issueI think this should achieve the issue while keeping the code compact and readable for what is a fairly marginal feature (the
vector_layersJSON isn't used by most consumers). I've done some moderate testing on this but would be happy to see further reports.