support transpilation of STRTOK from snowflake to duckdb#7283
Open
fivetran-felixhuang wants to merge 3 commits intomainfrom
Open
support transpilation of STRTOK from snowflake to duckdb#7283fivetran-felixhuang wants to merge 3 commits intomainfrom
fivetran-felixhuang wants to merge 3 commits intomainfrom
Conversation
geooo109
reviewed
Mar 13, 2026
| exp.Soundex, | ||
| exp.SoundexP123, | ||
| exp.SplitPart, | ||
| exp.Strtok, |
Collaborator
There was a problem hiding this comment.
Lets also include a test for this (in the annotate_functions)
Collaborator
Author
There was a problem hiding this comment.
there is a test for Strtok already (4955)
e4beaf1 to
f3ed4ca
Compare
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 99022 total, 97448 passed (pass rate: 98.4%), sqlglot version: sqlglot:transpile_strtok_snowflake_duckdb: 99022 total, 97435 passed (pass rate: 98.4%), sqlglot version: Transitions: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.snowflake.com/en/sql-reference/functions/strtok
DuckDB doesn't have strtok, so we need to leverage REGEXP_SPLIT_TO_ARRAY to implement Snowflake's behaviors.
There are some special Snowflake behaviors that we need to take care of:
For more details on this please check the comments in strtok_sql
Testing
Source Snowflake query
The transpiled query works except for the problematic statements that contain the escape character '' in the input or delimiter