feat(duckdb): Add transpilation support for Snowflake STARTS WITH#7709
Open
fivetran-kwoodbeck wants to merge 3 commits into
Open
feat(duckdb): Add transpilation support for Snowflake STARTS WITH#7709fivetran-kwoodbeck wants to merge 3 commits into
fivetran-kwoodbeck wants to merge 3 commits into
Conversation
Contributor
SQLGlot Integration Test Results✅ All tests passedComparing:
Overallmain: 113231 total, 112182 passed (pass rate: 99.1%) sqlglot:transpile/snowflake-startswith: 106860 total, 106860 passed (pass rate: 100.0%) Transitions: Dialect pair changes: 0 previous results not found, 2 current results not found ✅ All tests passed |
90cc2e1 to
9c55e84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Snowflake to DuckDB transpilation for
START WITH ... CONNECT BY PRIORhierarchical queries.DuckDB rejects
CONNECT BYverbatim. This addsconnect_by_to_recursive_cteregistered as a preprocessor onexp.Select, which rewrites the query into aWITH RECURSIVE CTEat generation time:START WITHrows from the source table_child_rowjoined to theCTEaliased _parent_row on thePRIORpredicateSELECTre-projects from_rootcte, applyingWHEREpost-hierarchy and forwardingORDER BY, LIMIT, OFFSETFalls through unchanged for
NOCYCLE, multiplePRIORs, or non-equality predicates. CTE name collision is avoided viafind_new_name.WHEREcolumns absent fromSELECTare carried through the CTE so the outer filter can see them.LEVELis injected as a depth counter unless already projected.Tests in sqlglot-integration-tests cover: SELECT *, explicit column list with ORDER BY, PRIOR on left side, WHERE carry-through, existing CTE preservation, and name collision.