Skip to content

Fix wheel ABI: produce .abi3.so to match cp312-abi3 wheel tag #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tohtsky merged 1 commit into from
May 15, 2026
Merged

Fix wheel ABI: produce .abi3.so to match cp312-abi3 wheel tag #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,16 @@ include(CPack)


# Detect the installed nanobind package and import it into CMake
find_package(Python 3.8 COMPONENTS Interpreter ${DEV_MODULE} REQUIRED)
find_package(Python 3.8 COMPONENTS Interpreter ${DEV_MODULE} ${SKBUILD_SABI_COMPONENT} REQUIRED)
execute_process(
COMMAND "${Python_EXECUTABLE}" -m nanobind --cmake_dir
OUTPUT_STRIP_TRAILING_WHITESPACE OUTPUT_VARIABLE nanobind_ROOT)
find_package(nanobind CONFIG REQUIRED)

nanobind_add_module(_ials_core cpp_source/als/wrapper.cpp)
nanobind_add_module(_knn cpp_source/knn/wrapper.cpp)
nanobind_add_module(_util_cpp cpp_source/util.cpp)
nanobind_add_module(_core_evaluator cpp_source/evaluator.cpp)
nanobind_add_module(_ials_core STABLE_ABI cpp_source/als/wrapper.cpp)
nanobind_add_module(_knn STABLE_ABI cpp_source/knn/wrapper.cpp)
nanobind_add_module(_util_cpp STABLE_ABI cpp_source/util.cpp)
nanobind_add_module(_core_evaluator STABLE_ABI cpp_source/evaluator.cpp)

install(TARGETS _ials_core LIBRARY DESTINATION irspack/recommenders)
install(TARGETS _core_evaluator LIBRARY DESTINATION irspack/evaluation)
Expand Down
Loading