Clear up some error handling in the Filesystem source#4811
Open
camgunz wants to merge 1 commit intofs-source-improve-logging-and-context-managementfrom
Open
Clear up some error handling in the Filesystem source#4811camgunz wants to merge 1 commit intofs-source-improve-logging-and-context-managementfrom
camgunz wants to merge 1 commit intofs-source-improve-logging-and-context-managementfrom
Conversation
camgunz
force-pushed
the
fs-source-improve-error-handling
branch
from
b876bea to
6c2f1c3
Compare
kashifkhan0771
approved these changes
Mar 12, 2026
shahzadhaider1
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Error handling wasn't too bad here, but it was a little inconsistent in very similar sections, making it hard to see that all we're doing is dispatching a different
scan*method based on the thing we're trying to scan.I also added a few newlines and removed a few outdated or superfluous comments.