Fix samples(n) regression; add ruff + ty checks#5
Open
events555 wants to merge 10 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduced type-checking (
ty) and a linter (ruff) to catch errors during CI. There was a regression with the_samples_dict()call wheretime_columnandtitle_rowwere being passed but unhandled.Fixed
_SamplesDict.__call__no longer forwardstime_column/title_rowto_samples_dict(5e202dc)Nonetype in_Rpc.__repr__,_RpcActionreturnsNone, reply-type asserts in_call(8a55bb3)libudev),tydependency resolution (ipython), and Node 24 action bumps (cd63c0f)Added
_twinleafRust extension module (5157364)ruff+ty(3c243da)Changed
ruffandtyinpyproject.toml(dbb9ddd)ruff format(284dd9e)Release