Skip to content

Change secrets to dotenv based instead of config files#140

Open
e-wai wants to merge 1 commit intomasterfrom
dotenv
Open

Change secrets to dotenv based instead of config files#140
e-wai wants to merge 1 commit intomasterfrom
dotenv

Conversation

@e-wai
Copy link
Collaborator

@e-wai e-wai commented Aug 14, 2021

Just another way to storing secrets, do you like it better? It means we just send around the .env file to whoever needs it, and it would get placed as routemodel/data_retrieval/.env

@e-wai e-wai requested review from mdshiozaki and ufshk August 14, 2021 19:17
@e-wai
Copy link
Collaborator Author

e-wai commented Sep 9, 2021

One more comment - config is used elsewhere as a directory, and seems to conflict with virtualenv files: venv\lib\site-packages\config\__init__.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant