fix: Safeguard onSuccess callback to prevent errors when undefined#4219
Open
mori-hisayuki wants to merge 1 commit intovercel:mainfrom
Open
fix: Safeguard onSuccess callback to prevent errors when undefined#4219mori-hisayuki wants to merge 1 commit intovercel:mainfrom
mori-hisayuki wants to merge 1 commit intovercel:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an infinite loop caused by explicitly passing
onSuccess: undefinedinuseSWRoptions.Problem
When
onSuccess: undefinedis passed as a config property, it overrides the defaultnoopfunction during config merging (mergeObjectsuses object spread). This causesgetConfig().onSuccess(...)to throw aTypeError, which is caught internally and triggers an error retry, resulting in an infinite request loop.This commonly occurs when a custom hook accepts an optional
onSuccesscallback and passes it directly touseSWR:Fix
Added optional chaining (
?.) to theonSuccessinvocation inuse-swr.tsso that anundefinedcallback is safely skipped instead of throwing.Related issue
Closes #4218