fix(cli): add managed bin to hook path#1647
Merged
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
05e3832 to
66db44e
Compare
Member
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66db44e7e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fengmk2
reviewed
May 21, 2026
6456bf4 to
fbba442
Compare
fbba442 to
fdd0e1f
Compare
fengmk2
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When committing via VS Code on MacOS I hit the error
But node was installed and
vp env doctorwas happy.The issues seemed that the managed Node is not available in the Git hook.
I learned that Git hooks often run with a much smaller, non-interactive
PATH, possibly not including the shims.In my case, path was limited to what is shared in the error above. That included the local
vpbin but notnode, leading to the error.The PR fixes that by making generated hooks add Vite+’s managed bin directory before running the user hook. Then
vp stagedcan start even when Git launches the hook with a restricted PATH.