feat(migration): skip rewriting imports for packages in peerDependencies#367
Merged
feat(migration): skip rewriting imports for packages in peerDependencies#367
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
force-pushed
the
dont-rewrite-vite-on-peer-deps
branch
2 times, most recently
from
ddeb301 to
5bb32a4
Compare
fengmk2
force-pushed
the
dont-rewrite-vite-on-peer-deps
branch
from
5bb32a4 to
9f1d497
Compare
fengmk2
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds intelligent peer dependency handling to the Vite migration tool, preventing accidental bundling of vite-plus into libraries that depend on Vite as a peer dependency (like Vite plugins).
Key Changes:
- Split monolithic AST-grep rules into separate VITE, VITEST, and TSDOWN rule sets for selective application
- Implemented package.json peerDependencies detection with per-file resolution
- Added caching mechanism to optimize package.json reads in monorepos
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
crates/vite_migration/src/import_rewriter.rs |
Core implementation: split AST rules, added SkipPackages logic, implemented nearest package.json resolution, added comprehensive unit tests |
packages/global/src/utils/workspace.ts |
Added node_modules exclusion to workspace package discovery |
packages/global/snap-tests/migration-skip-vite-peer-dependency/* |
Snap test for single-package scenario with vite in peerDependencies |
packages/global/snap-tests/migration-monorepo-skip-vite-peer-dependency/* |
Snap test for monorepo scenario with different peerDependencies per package |
ecosystem-ci/repo.json |
Added vite-plugin-react to ecosystem CI |
ecosystem-ci/.gitignore |
Added vite-plugin-react to gitignore |
.github/workflows/e2e-test.yml |
Added vite-plugin-react E2E test configuration and pull_request trigger |
CLAUDE.md |
Added build and snap-test instructions documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengmk2
commented
Dec 26, 2025
fengmk2
force-pushed
the
dont-rewrite-vite-on-peer-deps
branch
from
9f1d497 to
41f5174
Compare
Deploying vite-plus with
|
| Latest commit: |
927dd23
|
| Status: | 🚫 Build failed. |
fengmk2
force-pushed
the
dont-rewrite-vite-on-peer-deps
branch
from
41f5174 to
8435a43
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengmk2
force-pushed
the
dont-rewrite-vite-on-peer-deps
branch
from
8435a43 to
f663046
Compare
fengmk2
force-pushed
the
dont-rewrite-vite-on-peer-deps
branch
from
f663046 to
33874b2
Compare
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengmk2
force-pushed
the
dont-rewrite-vite-on-peer-deps
branch
from
33874b2 to
6e9016f
Compare
fengmk2
changed the base branch from
graphite-base/367
to
01-04-test_e2e_skip_rollipop_lint_check
fengmk2
changed the base branch from
01-04-test_e2e_skip_rollipop_lint_check
to
main
fengmk2
force-pushed
the
dont-rewrite-vite-on-peer-deps
branch
from
6e9016f to
6ed5f3a
Compare
fengmk2
force-pushed
the
dont-rewrite-vite-on-peer-deps
branch
from
6ed5f3a to
fdfd022
Compare
fengmk2
force-pushed
the
dont-rewrite-vite-on-peer-deps
branch
from
fdfd022 to
63f9d5a
Compare
fengmk2
force-pushed
the
graphite-base/367
branch
from
4a5de30 to
60194e3
Compare
fengmk2
changed the base branch from
graphite-base/367
to
merge-json-config-support-jsonc-format
graphite-app
bot
changed the base branch from
merge-json-config-support-jsonc-format
to
main
Merge activity |
fengmk2
force-pushed
the
dont-rewrite-vite-on-peer-deps
branch
from
63f9d5a to
927dd23
Compare
fengmk2
changed the base branch from
graphite-base/367
to
merge-json-config-support-jsonc-format
Brooooooklyn
approved these changes
Jan 6, 2026
fengmk2
changed the base branch from
merge-json-config-support-jsonc-format
to
graphite-base/367
…ndencies When a project has vite in peerDependencies (like a Vite plugin), the import rewriter now skips rewriting vite imports to avoid accidentally bundling vite-plus into the library. - Split AST-grep rules into separate VITE, VITEST, and TSDOWN rule sets - Added get_skip_packages_from_root() to check root package.json for peerDependencies - Apply rules conditionally based on which packages are in peerDependencies - Added comprehensive unit tests for peerDependencies scenarios - Added snap test: migration-skip-vite-peer-dependency - Updated CLAUDE.md with build and snap-test instructions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Find the nearest package.json for each source file instead of only checking the root. This allows monorepos to have different packages with different peerDependencies - a vite plugin package can have vite in peerDependencies (imports preserved) while an app package without peerDependencies will have imports rewritten. - Add find_nearest_package_json() to walk up directories - Cache package.json lookups for performance - Add monorepo unit tests and snap-test 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
fengmk2
force-pushed
the
graphite-base/367
branch
from
65ceee6 to
6e4eef6
Compare
fengmk2
force-pushed
the
dont-rewrite-vite-on-peer-deps
branch
from
927dd23 to
9a4de13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a project has vite in peerDependencies (like a Vite plugin), the
import rewriter now skips rewriting vite imports to avoid accidentally
bundling vite-plus into the library.
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com