Skip to content

fix(env): check vpx shim in vp env doctor#876

Merged
fengmk2 merged 3 commits intovoidzero-dev:mainfrom
MahmoodKhalil57:fix/doctor-missing-vpx-shim
Mar 15, 2026
Merged

fix(env): check vpx shim in vp env doctor#876
fengmk2 merged 3 commits intovoidzero-dev:mainfrom
MahmoodKhalil57:fix/doctor-missing-vpx-shim

Conversation

@MahmoodKhalil57
Copy link
Copy Markdown
Contributor

@MahmoodKhalil57 MahmoodKhalil57 commented Mar 14, 2026

Summary

  • vp env setup creates shims for ["node", "npm", "npx", "vpx"]
  • vp env doctor only checked ["node", "npm", "npx"], missing vpx
  • A broken or missing vpx shim was invisible to the doctor

Fixes #880

One-line change in crates/vite_global_cli/src/commands/env/doctor.rs.

Context

setup.rs:24 defines:

const SHIM_TOOLS: &[&str] = &["node", "npm", "npx", "vpx"];

But doctor.rs:25 had:

const SHIM_TOOLS: &[&str] = &["node", "npm", "npx"];

This also means the PATH section's tool-resolution check (line 373) skipped vpx.

`vp env setup` creates shims for node, npm, npx, and vpx, but
`vp env doctor` only verified node, npm, and npx. A missing vpx
shim would go undetected with "All checks passed".

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 14, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit b989ab0
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69b69f3f8317560008c670f9

@fengmk2 fengmk2 merged commit caf61af into voidzero-dev:main Mar 15, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(env): vp env doctor doesn't verify the vpx shim

2 participants