ci: extract clippy into its own job and remove redundant compilation#250
Merged
ci: extract clippy into its own job and remove redundant compilation#250
Conversation
Each test matrix entry was running `cargo check`, `cargo clippy`, and `cargo test` — effectively compiling 3x per platform. Clippy (a lint) also ran identically on all 4 platforms when once is sufficient. - Add dedicated `clippy` job on ubuntu-latest, parallel to test jobs - Remove `cargo check` and `cargo clippy` steps from test matrix - Move `-D warnings` into `.cargo/config.toml` rustflags so all compilations enforce warnings-as-errors consistently without env overrides (which would clobber config.toml rustflags for musl targets) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The removed `cargo check --locked` was the only step verifying Cargo.lock is up to date. Add --locked to clippy which serves the same purpose. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42da5f166c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The bindep crate (fspy_test_bin) requires the x86_64-unknown-linux-musl target when building with --all-targets. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The musl linker wrapper for the fspy_test_bin bindep invokes cargo-zigbuild, so it must be available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-latestin parallel with all test jobs, instead of running identically on all 4 platformscargo checkandcargo clippyfrom test matrix entries — each was compiling the codebase ~3x per platform (check + clippy + test)-D warningsinto.cargo/config.tomlrustflags so warnings-as-errors is enforced consistently without envRUSTFLAGSoverrides (which clobber config.toml rustflags, breaking musl linker settings)Expected critical path improvement: ~30-40% faster (Windows drops from ~10min to ~6-7min).
🤖 Generated with Claude Code