Skip to content

feat: make dispatch plan dynamically sized#7186

Merged
0ax1 merged 2 commits intodevelopfrom
ad/check-max-shared-limit
Mar 27, 2026
Merged

feat: make dispatch plan dynamically sized#7186
0ax1 merged 2 commits intodevelopfrom
ad/check-max-shared-limit

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Mar 26, 2026

Replace the fixed-size DynamicDispatchPlan struct with a variable-length packed byte buffer, removing the MAX_STAGES and MAX_SCALAR_OPS limits.

@0ax1 0ax1 added the changelog/feature A new feature label Mar 26, 2026
@0ax1 0ax1 force-pushed the ad/check-max-shared-limit branch from 04d9f11 to e5c3e6c Compare March 26, 2026 21:01
@0ax1 0ax1 requested review from a10y and robert3005 March 26, 2026 21:01
@0ax1 0ax1 force-pushed the ad/check-max-shared-limit branch from e5c3e6c to 1a28a3c Compare March 26, 2026 21:02
Replace the fixed-size DynamicDispatchPlan struct with a variable-length
packed byte buffer, removing the MAX_STAGES and MAX_SCALAR_OPS limits.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 force-pushed the ad/check-max-shared-limit branch from 1a28a3c to f5c9361 Compare March 26, 2026 21:05
@0ax1 0ax1 requested a review from myrrc March 27, 2026 12:33
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 requested a review from AdamGS March 27, 2026 14:33
@0ax1 0ax1 enabled auto-merge (squash) March 27, 2026 14:34
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 27, 2026

Merging this PR will degrade performance by 15.51%

❌ 2 regressed benchmarks
✅ 1104 untouched benchmarks
⏩ 1522 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 317.8 ns 376.1 ns -15.51%
Simulation bitwise_not_vortex_buffer_mut[1024] 477.2 ns 535.6 ns -10.89%

Comparing ad/check-max-shared-limit (b340968) with develop (6fade3c)

Open in CodSpeed

Footnotes

  1. 1522 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@0ax1 0ax1 merged commit 5369859 into develop Mar 27, 2026
58 of 59 checks passed
@0ax1 0ax1 deleted the ad/check-max-shared-limit branch March 27, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants