Skip to content

expose execution context for validity::to_bool and remove validity mask from array vtable#7432

Open
joseph-isaacs wants to merge 10 commits intodevelopfrom
ji/all-around-cdtx
Open

expose execution context for validity::to_bool and remove validity mask from array vtable#7432
joseph-isaacs wants to merge 10 commits intodevelopfrom
ji/all-around-cdtx

Conversation

@joseph-isaacs
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

# Conflicts:
#	vortex-array/src/arrays/primitive/compute/cast.rs
@joseph-isaacs joseph-isaacs added the changelog/chore A trivial change label Apr 14, 2026
@joseph-isaacs joseph-isaacs marked this pull request as ready for review April 14, 2026 19:22
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 14, 2026

Merging this PR will degrade performance by 23.2%

⚡ 36 improved benchmarks
❌ 16 regressed benchmarks
✅ 1095 untouched benchmarks
⏩ 1455 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bench_many_codes_few_values[1024] 294 µs 367 µs -19.9%
Simulation bench_many_codes_few_values[2048] 296.8 µs 369.9 µs -19.74%
Simulation bench_many_nulls[0.5] 326.6 µs 364.9 µs -10.49%
Simulation bench_sparse_coverage[0.1] 294 µs 367.1 µs -19.89%
Simulation bench_sparse_coverage[0.5] 292.8 µs 365.9 µs -19.96%
Simulation bench_sparse_coverage[0.01] 365.4 µs 438.5 µs -16.67%
Simulation bench_many_codes_few_values[4096] 302.9 µs 375.9 µs -19.43%
Simulation bench_many_nulls[0.9] 472.8 µs 540.3 µs -12.49%
Simulation take_search[(0.005, 0.05)] 168.4 µs 131.9 µs +27.66%
Simulation take_search[(0.01, 0.1)] 341.3 µs 268.4 µs +27.16%
Simulation take_search[(0.01, 0.05)] 179.5 µs 143 µs +25.53%
Simulation take_search[(0.005, 0.5)] 1.5 ms 1.2 ms +31.01%
Simulation take_search[(0.005, 1.0)] 3.1 ms 2.3 ms +31.25%
Simulation take_search[(0.005, 0.1)] 320.6 µs 247.6 µs +29.44%
Simulation take_search[(0.01, 1.0)] 3.3 ms 2.5 ms +28.77%
Simulation take_search[(0.1, 0.05)] 249.3 µs 212.7 µs +17.17%
Simulation take_search[(0.1, 0.1)] 458.9 µs 386 µs +18.9%
Simulation take_search[(0.1, 0.5)] 2.2 ms 1.8 ms +20.39%
Simulation take_search[(0.01, 0.5)] 1.6 ms 1.3 ms +28.56%
Simulation take_search_chunked[(0.005, 0.1)] 384.1 µs 322.3 µs +19.17%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing ji/all-around-cdtx (d634965) with develop (f747201)

Open in CodSpeed

Footnotes

  1. 1455 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant