Skip to content

grouped aggregate microbenches#8301

Merged
onursatici merged 2 commits into
developfrom
os/grouped-agg-bench
Jun 9, 2026
Merged

grouped aggregate microbenches#8301
onursatici merged 2 commits into
developfrom
os/grouped-agg-bench

Conversation

@onursatici

Copy link
Copy Markdown
Contributor

Summary

Add a couple of grouped aggregation divan benchmarks

Signed-off-by: Onur Satici <onur@spiraldb.com>
@onursatici onursatici requested a review from a team June 8, 2026 15:20
@onursatici onursatici added the changelog/skip Do not list PR in the changelog label Jun 8, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 8, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 11.94%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 3 improved benchmarks
❌ 1 regressed benchmark
✅ 1509 untouched benchmarks
🆕 4 new benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation encode_varbin[(1000, 2)] 143.1 µs 163.7 µs -12.58%
Simulation bitwise_not_vortex_buffer_mut[128] 275.3 ns 216.9 ns +26.89%
Simulation bitwise_not_vortex_buffer_mut[1024] 336.9 ns 278.6 ns +20.94%
Simulation bitwise_not_vortex_buffer_mut[2048] 400.6 ns 342.2 ns +17.05%
🆕 Simulation count_i32_clustered_nulls N/A 685.2 µs N/A
🆕 Simulation count_varbinview N/A 255.2 µs N/A
🆕 Simulation sum_i32_clustered_nulls N/A 594.3 µs N/A
🆕 Simulation sum_i32_nullable_all_valid N/A 351.7 µs N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing os/grouped-agg-bench (b2221df) with develop (1b19ac9)

Open in CodSpeed

@joseph-isaacs

Copy link
Copy Markdown
Contributor

All microbenchmarks must be less than 1ms

@robert3005

Copy link
Copy Markdown
Contributor

These aren't very micro benches

@onursatici

Copy link
Copy Markdown
Contributor Author

micro 🅱️enches

Signed-off-by: Onur Satici <onur@spiraldb.com>
@onursatici onursatici enabled auto-merge (squash) June 9, 2026 10:26
@onursatici onursatici merged commit 4897a5b into develop Jun 9, 2026
90 of 93 checks passed
@onursatici onursatici deleted the os/grouped-agg-bench branch June 9, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants