fix: check for __VUE_INSPECTOR__ before calling openInEditor#1098
Open
Akur1a wants to merge 1 commit into
Open
fix: check for __VUE_INSPECTOR__ before calling openInEditor#1098Akur1a wants to merge 1 commit into
Akur1a wants to merge 1 commit into
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
When Options API is disabled via @vitejs/plugin-vue features config, the Vue compiler does not initialize __VUE_INSPECTOR__, causing a TypeError when trying to open a component in the editor. Add a null check for target.__VUE_INSPECTOR__ before calling openInEditor, and log a helpful warning when the inspector is not available. Fixes vuejs#824
Akur1a
force-pushed
the
fix/open-in-editor-options-api
branch
from
6af80b4 to
111f768
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When Options API is disabled, the component inspector may not be initialized. This guards the open-in-editor call so the devtools do not throw when
__VUE_INSPECTOR__is unavailable.Fixes #824