Skip to content

chore: update schemas for Riot API changes#18

Closed
github-actions[bot] wants to merge 2 commits into
mainfrom
schema-drift-update
Closed

chore: update schemas for Riot API changes#18
github-actions[bot] wants to merge 2 commits into
mainfrom
schema-drift-update

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Automated schema drift detection found changes in Riot API response shapes.

Review the diff to understand what changed.

wardbox and others added 2 commits April 27, 2026 12:03
The schema-drift workflow was missing the `version` input for
pnpm/action-setup@v4, causing it to error out before running. All other
workflows pin 10.11.0 — match that.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Base automatically changed from fix/schema-drift-pnpm-version to main April 27, 2026 19:10
@wardbox
Copy link
Copy Markdown
Owner

wardbox commented Apr 27, 2026

Closing without merging — drift detection ran on a bad data sample.

Why this PR isn't safe to merge:

  1. Empty-list schema regressionlol-status-v4 lost the full structure of maintenance/incident items (87 lines dropped) because Riot's live status endpoint returned empty arrays at capture time. The inference-based generator can't infer item shape from zero samples. Merging would delete type info real consumers rely on.

  2. Wholesale JSDoc deletion in every generated .ts file (lol/val/tft/lor/riftbound/riot). Hundreds of field-level tooltips removed.

  3. 403 Forbidden on TFT/VAL/LoR endpoints — discovery log confirms Riot API error 403: Forbidden on TFT challenger. val.ts lost 222 lines net, tft.ts/lor.ts similarly gutted because the dev API key lacks product access for those games.

  4. Conflicts with main — branch was cut before ci: pin pnpm version in schema-drift workflow #17 and ci: upgrade actions to Node 24 versions #19, so it duplicates the schema-drift fix and is missing the action-version bumps.

Next step: re-run schema drift after enabling full TFT/VAL/LoR product access on the dev API key, and consider hardening the generator to preserve prior shapes when the current sample is empty or forbidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant