Merged
Conversation
- update tests - refactor shit
Remove Math.round from injectWebviewOverlay to preserve float precision. In getMobileViewPortPosition, derive dimensions from edges and cap to screen bounds to guarantee consistent sums. Made-with: Cursor
🦋 Changeset detectedLatest commit: 31246b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- add new tests - add new images
Keeping the bidi to viewport resulted in issues with elements that were not in the view. This fixes it
…nshots on desktop - Add `ignoreRegionPadding` to element/screen check & save flows and apply it in web element/screen ignore region calculations - Wire `ignoreRegionPadding` through visual-service matchers and update related unit tests/snapshots and desktop/BiDi specs
…shot scale - Output ignore regions in CSS pixel coordinates in `determineWebElementIgnoreRegions` when `isAndroidNativeWebScreenshot` and `isWebDriverElementScreenshot` are both true (native driver image is at CSS size) - Pass `isAndroidNativeWebScreenshot` and `isWebDriverElementScreenshot` from `saveWebElement` into `determineWebElementIgnoreRegions` - Add unit test for the Android native web + native driver downscale path
- there's a bug in the driver, it will only create a screenshot of the the visual part, but will keep the dimensions of the original element
- add iignoreRegionPadding for fullpage and make it generic
- Revert injectWebviewOverlay.ts to use Math.round() for viewport data collection, fixing ~0.2% fullpage stitching mismatches on Android - Revert getMobileViewPortPosition to main's calculation logic, removing Math.min clamping that caused viewport dimension inconsistencies - Fix scrollElementIntoView to account for current scroll position when computing target scroll offset (BCR.top is viewport-relative, not document-absolute), preventing blank iOS element screenshots - Update unit tests and regenerate affected Android fullpage baselines Made-with: Cursor
the caps didn't always work. Now we have this fixed in a more elegant way which is handled by the module
- update images - add more tests
- fix pipeline - fix native app rectangles
…brid status bar fallback - Use the device's platform version to select the correct offsets entry for the hybrid-app status bar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
ignoreoption for web, see also #857 . The difference betweenignore,hideandremoveis thatignorewill completely ignore the element and puts an overlay when a diff is created. This PR will consist out of multiple steps that will be explained below:beforeScreenshotcauses Safari to evict all cached element references. Need to fix this for iOS specificallyWe also implemented skip rules in the tests for mobile to track which tests might have issues that needs to be fixed or which logic might be broken which needs to be fixed but not mandatory for the next release