refactor: code around only negative flags

Author: alexander-akait

packages/webpack-cli/src/webpack-cli.ts

@@ -874,10 +874,16 @@ class WebpackCLI {
       }
 
       command.addOption(optionForCommand);
-    }
+    } else if (mainOption.type.size === 0 && negativeOption) {
+      const optionForCommand = new Option(mainOption.flags, mainOption.description);
+
+      // Hide stub option
+      optionForCommand.flags = "";
+      optionForCommand.hidden = option.hidden || true;
+      (optionForCommand as Option & { internal?: boolean }).internal = true;
 
-    // A situation arises when `mainOption.type.size === 0 && negativeOption`
-    // In this case, we don't create the option, since this means the option only has a negative value
+      command.addOption(optionForCommand);
+    }
 
     if (negativeOption) {
       const optionForCommand = new Option(negativeOption.flags, negativeOption.description).default(
@@ -1043,6 +1049,10 @@ class WebpackCLI {
         },
         visibleOptions: function visibleOptions(command) {
           return command.options.filter((option) => {
+            if ((option as Option & { internal?: boolean }).internal) {
+              return false;
+            }
+
             // Hide `--watch` option when developer use `webpack watch --help`
             if (
               (options[0] === "w" || options[0] === "watch") &&
@@ -1977,7 +1987,10 @@ class WebpackCLI {
             }
 
             for (const option of command.options) {
-              if (distance(name, option.long?.slice(2) as string) < 3) {
+              if (
+                !(option as Option & { internal?: boolean }).internal &&
+                distance(name, option.long?.slice(2) as string) < 3
+              ) {
                 this.logger.error(`Did you mean '--${option.name()}'?`);
               }
             }

test/build/core-flags/core-flags.test.js

@@ -108,8 +108,7 @@ describe("core flags", () => {
       const { exitCode, stderr, stdout } = await run(__dirname, ["--amd"]);
 
       expect(exitCode).toBe(2);
-      expect(stderr).toContain("Invalid value 'true' for the '--amd' option");
-      expect(stderr).toContain("Expected: 'false'");
+      expect(stderr).toContain("Unknown option '--amd");
       expect(stdout).toBeFalsy();
     });