Skip to content

chore: update http-proxy-middleware#5663

Draft
bjohansebas wants to merge 6 commits intonextfrom
proxy
Draft

chore: update http-proxy-middleware#5663
bjohansebas wants to merge 6 commits intonextfrom
proxy

Conversation

@bjohansebas
Copy link
Copy Markdown
Member

Summary
changelog: https://github.com/chimurai/http-proxy-middleware/blob/master/CHANGELOG.md#next

fixed: #5306

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Use of AI

@chimurai
Copy link
Copy Markdown
Contributor

chimurai commented May 5, 2026

final version is published:

@alexander-akait
Copy link
Copy Markdown
Member

Thanks, we will make a release soon too with update version, around 2 weeks, maybe faster

@bjohansebas
Copy link
Copy Markdown
Member Author

Cool, now Jest seems to support require(esm), so nice

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49.71%. Comparing base (a7ab30f) to head (ea1a3b6).

Files with missing lines Patch % Lines
lib/Server.js 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a7ab30f) and HEAD (ea1a3b6). Click for more details.

HEAD has 34 uploads less than BASE
Flag BASE (a7ab30f) HEAD (ea1a3b6)
36 2
Additional details and impacted files
@@             Coverage Diff             @@
##             next    #5663       +/-   ##
===========================================
- Coverage   83.73%   49.71%   -34.02%     
===========================================
  Files          11       11               
  Lines        1943     1945        +2     
  Branches      719      720        +1     
===========================================
- Hits         1627      967      -660     
- Misses        283      811      +528     
- Partials       33      167      +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix test and we can merge

@bjohansebas
Copy link
Copy Markdown
Member Author

Dam, Jest's require(esm) support requires Node 24, so I'll have to continue with the migration

@bjohansebas
Copy link
Copy Markdown
Member Author

Or I could compile http-middleware-proxy with Babel so it transforms it to CommonJS, and then I wouldn’t have to affect anything else. The main problem is really Jest, because everything else should work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants