Improve token path handling #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Draft for now. Requires new GH action and PR #84 to be merged for the Windows issue. |
LinuxJedi
force-pushed
the
token-path
branch
3 times, most recently
from
7034d1d to
7625e61
Compare
Member
Author
julek-wolfssl
requested changes
Jun 4, 2025
Old behaviour for token persistent storage: 1. If `WOLFPKCS11_TOKEN_PATH` env var is set and wolfPKCS11 was not compiled with `WOLFPKCS11_NO_ENV`, this path is used. 2. Otherwise `/tmp` is used. New behaviour: 1. If `WOLFPKCS11_TOKEN_PATH` env var is set and wolfPKCS11 was not compiled with `WOLFPKCS11_NO_ENV`, this path is used. 2. `$HOME/.wolfPKCS11` in *nix and `%APPDIR%/wolfPKCS11` is used in Windows. 3. `WOLFPKCS11_DEFAULT_TOKEN_PATH` is used if set, this can be set with `--with-default-token-path`. 4. `/tmp` is used as a lowest priority fallback.
Member
|
Windows failing on some unresolved tpm symbols |
Member
|
Windows failure to be fixed in #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old behaviour for token persistent storage:
WOLFPKCS11_TOKEN_PATHenv var is set and wolfPKCS11 was not compiled withWOLFPKCS11_NO_ENV, this path is used./tmpis used.New behaviour:
WOLFPKCS11_TOKEN_PATHenv var is set and wolfPKCS11 was not compiled withWOLFPKCS11_NO_ENV, this path is used.$HOME/.wolfPKCS11in *nix and%APPDATA%/wolfPKCS11is used in Windows.WOLFPKCS11_DEFAULT_TOKEN_PATHis used if set, this can be set with--with-default-token-path./tmpis used as a lowest priority fallback.