Refactor wp config create to set config values through WPConfigTransformer#226
Open
Copilot wants to merge 10 commits into
Open
Refactor wp config create to set config values through WPConfigTransformer#226Copilot wants to merge 10 commits into
wp config create to set config values through WPConfigTransformer#226Copilot wants to merge 10 commits into
Conversation
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor config command to always validate in config transformer library
Refactor May 27, 2026
wp config create to set config values through WPConfigTransformer
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
340
to
342
| $wp_config_file_name = basename( $assoc_args['config-file'] ); | ||
| $created_config_file = ! file_exists( $assoc_args['config-file'] ); | ||
| $bytes_written = file_put_contents( $assoc_args['config-file'], $out ); |
Comment on lines
+439
to
+443
| if ( $created_config_file && file_exists( $assoc_args['config-file'] ) ) { | ||
| if ( ! unlink( $assoc_args['config-file'] ) ) { | ||
| $cleanup_error = "\nCleanup: Could not remove '{$wp_config_file_name}' after failure."; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wp config createstill had a separate value-writing path from the transformer-backed commands, which duplicated escaping/validation behavior and made new validation logic hard to centralize. This change makescreatea thin wrapper: render defaults first, then apply requested values throughwp-cli/wp-config-transformer.Create flow now routes value writes through transformer
wp-config.mustachewith baseline defaults (including empty placeholders for salts when needed).WPConfigTransformer::update().WPConfigTransformer::update()when salts are generated.Removed create-specific escaping path
escape_config_value()path used only bycreate.Focused feature coverage for transformer-path escaping
config createfeature scenario covering special-character handling forDB_CHARSETto ensure values written through the transformer are preserved and readable viawp config get.